Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot configure --metric-labels-allowlist when KSM is used as a Go dependency #1515

Closed
ahmed-mez opened this issue Jun 28, 2021 · 0 comments · Fixed by #1514
Closed

Cannot configure --metric-labels-allowlist when KSM is used as a Go dependency #1515

ahmed-mez opened this issue Jun 28, 2021 · 0 comments · Fixed by #1514
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ahmed-mez
Copy link
Contributor

What happened:

When used as a dependency, it's impossible to configure the labels allowlist.

What you expected to happen:

The public BuilderInterface exposes a method to configure the labels allowlist, especially with the new behaviour in KSM v2 where the labels are dropped by default as reported in #1489

How to reproduce it (as minimally and precisely as possible):

It's obvious in the code.

Anything else we need to know?:

A proposal to fix this #1514
@ahmed-mez ahmed-mez added the kind/bug Categorizes issue or PR as related to a bug. label Jun 28, 2021
@ahmed-mez ahmed-mez mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add WithAllowLabels to public BuilderInterface ahmed-mez/kube-state-metrics
1 participant
@ahmed-mez