-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithAllowLabels
to public BuilderInterface
#1514
Conversation
/assign @tariq1890 |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmed-mez, mrueg, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tariq1890 and @mrueg Thank you for reviewing and approving the PR! Really appreciated the maintainers' reactivity! Any chance we could get this back-ported to Thanks! |
@ahmed-mez Thanks for your contribution! Can you send a backport PR to the release-2.1 branch, that way we can make sure it will be in an upcoming 2.1.1 release. |
[release-2.1] Backport #1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
What this PR does / why we need it:
fixes: #1515
Add the method
WithAllowLabels
to publicBuilderInterface
.It provides an option to configure
--metric-labels-allowlist
whenkube-state-metrics
is used as a Go dependency of another project.