Add WithAllowLabels to public BuilderInterface
#1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
mrueg
approved these changes
Jun 25, 2021
|
/assign @tariq1890 |
k8s-ci-robot
added
size/S
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmed-mez, mrueg, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Hi @tariq1890 and @mrueg Thank you for reviewing and approving the PR! Really appreciated the maintainers' reactivity! Any chance we could get this back-ported to Thanks! |
|
@ahmed-mez Thanks for your contribution! Can you send a backport PR to the release-2.1 branch, that way we can make sure it will be in an upcoming 2.1.1 release. |
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 13, 2021
[release-2.1] Backport #1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 28, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Jul 29, 2021
* [CHANGE] Replace multiListWatcher with independent listWatchers per namespace kubernetes#1499 * [CHANGE] go.mod: Update and minimize dependencies kubernetes#1529 * [BUGFIX] Use BuilderInterface instead of internal/store.Builder in metricshandler kubernetes#1537 * [BUGFIX] Add WithAllowLabels to public BuilderInterface kubernetes#1514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fixes: #1515
Add the method
WithAllowLabelsto publicBuilderInterface.It provides an option to configure
--metric-labels-allowlistwhenkube-state-metricsis used as a Go dependency of another project.