"LabelFromKey" not avaliable

[hdxj-kaoy]

labelFromKey does not work when I use the config below

kube-state-metrics --port=8880 --telemetry-port=8881 --kubeconfig=/config --custom-resource-state-config-file=/crsm.yaml

crsm.yaml

kind: CustomResourceStateMetrics
spec:
  resources:
    - groupVersionKind:
        group: bbb
        kind: "xxx"
        version: "v1alpha1"
      labelsFromPath:
        name: [metadata, name]
      metrics:
        - name: "np"
          help: "xxx"
          each:
            type: Gauge
            gauge:
              path: [status, nodeProgress]
              # does not work
              labelFromKey: type

CR looks like:

apiVersion: bbb/v1alpha1
kind: xxx
  ...
  ...
  ...
status:
  np:
    key1: 100
    key2: 100

I got :

kube_bbb_v1alpha1_xxx_np{name="aaa"} 100
kube_bbb_v1alpha1_xxx_np{name="aaa"} 100

instead of

kube_bbb_v1alpha1_xxx_np{name="aaa",type="key1"} 100
kube_bbb_v1alpha1_xxx_np{name="aaa",type="key2"} 100

After checking the source code and changing

kube-state-metrics/pkg/customresourcestate/registry_factory.go

Lines 156 to 160 in a3a509a

	return &compiledGauge{
	compiledCommon: *cc,
	ValueFrom: valueFromPath,
	NilIsZero: m.Gauge.NilIsZero,
	}, nil

to

 return &compiledGauge{ 
 	compiledCommon: *cc, 
 	ValueFrom:      valueFromPath, 
 	NilIsZero:      m.Gauge.NilIsZero, 
	LabelFromKey:   m.Gauge.LabelFromKey,
 }, nil 

I get the result I want.

I wonder whether this is intentional or there are other solutions that do not need to modify the source code.

[rexagod]

/assign
I don't think this was intentional. This makes sense to me. #1871 is more or less similar to this as well.

[mrueg]

v2.7.0 has been released, feel free to reopen if this is not resolved.