Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube_lease_renew_time needs namespace label #2071

Closed
mrueg opened this issue May 19, 2023 · 2 comments · Fixed by #2073
Closed

kube_lease_renew_time needs namespace label #2071

mrueg opened this issue May 19, 2023 · 2 comments · Fixed by #2073
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mrueg
Copy link
Member

mrueg commented May 19, 2023

What happened:
The metric kube_lease_renew_time{lease="foo"} is describing a namespaced object but not exposing the namespace. This can lead to metric collisions if there are two leases in different namespaces.

What you expected to happen:

Expose the namespace label for kube_lease_renew_time in internal/store/lease.go

How to reproduce it (as minimally and precisely as possible):

Create two leases with the same name in different namespaces.

Anything else we need to know?:

Environment:

  • kube-state-metrics version: 2.8.2
  • Kubernetes version (use kubectl version): 1.23
  • Cloud provider or hardware configuration: Kind
  • Other info: None
@mrueg mrueg added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrueg mrueg added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 19, 2023
@a-hilaly
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants