kube_job_failed should have reason label

[keisku]

What would you like to be added:

Add reason label here other than condition.

kube-state-metrics/internal/store/job.go

Lines 292 to 316 in 9e6e70d

	*generator.NewFamilyGeneratorWithStability(
	"kube_job_failed",
	"The job has failed its execution.",
	metric.Gauge,
	basemetrics.STABLE,
	"",
	wrapJobFunc(func(j *v1batch.Job) *metric.Family {
	ms := []*metric.Metric{}
	for _, c := range j.Status.Conditions {
	if c.Type == v1batch.JobFailed {
	metrics := addConditionMetrics(c.Status)
	for _, m := range metrics {
	metric := m
	metric.LabelKeys = []string{"condition"}
	ms = append(ms, metric)
	}
	}
	}
	return &metric.Family{
	Metrics: ms,
	}
	}),
	),

Why is this needed:

Enable to monitor why a job fails.

Describe the solution you'd like

-- 					metric.LabelKeys = []string{"condition"}
++ 					metric.LabelKeys = []string{"condition", "reason"}

Additional context

I would like to know why the current implementation doesn't allow adding reason label. Any concerns?

[ricardoapl]

I would like to know why the current implementation doesn't allow adding reason label. Any concerns?

I don't know, but wouldn't using kube_job_status_failed instead of kube_job_failed solve your issue?

[logicalhan]

/triage accepted
/assign @CatherineF-dev

[CatherineF-dev]

Yes, kube_job_status_failed has reason.

kube-state-metrics/internal/store/job_test.go

Line 207 in 9e6e70d

kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="DeadlineExceeded"} 0

[CatherineF-dev]

/close

[k8s-ci-robot]

@CatherineF-dev: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.