Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss cutting kube-state-metrics v1.6.0 #697

Closed
mxinden opened this issue Mar 7, 2019 · 11 comments
Closed

Discuss cutting kube-state-metrics v1.6.0 #697

mxinden opened this issue Mar 7, 2019 · 11 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mxinden
Copy link
Contributor

mxinden commented Mar 7, 2019

Given that the last release was cut ~2 month ago and master being ahead of release-1.5 by 107 commits, what do you all think of cutting a v1.6.0 release?

@brancz
Copy link
Member

brancz commented Mar 7, 2019

Sounds good to me 👍

@tariq1890
Copy link
Contributor

Possible to fit PRs #610 and #654 into the release?

@brancz
Copy link
Member

brancz commented Mar 7, 2019

#654 is already merged, so yes, #610 I'm not so sure about as it will need some follow up and I'd be ok if it lands in the next release

@tariq1890
Copy link
Contributor

Whoops typo I meant #650

@tariq1890
Copy link
Contributor

Sure, I understand. Also, if it doesn't have any activity, I don't mind picking one of them up. We can also open it up to potential contributors in the Kubernetes slack. Thoughts?

@tariq1890
Copy link
Contributor

tariq1890 commented Mar 7, 2019

Or if we want to cut the 1.6.0 release sooner, we can just wait until the next minor release too.

@brancz
Copy link
Member

brancz commented Mar 7, 2019

Pinging people on kubernetes slack as a first measure sounds like a good idea. As we don’t have a regular release cadence, I think it’s ok to also cut the next minor release closer to this one if needed.

@tariq1890
Copy link
Contributor

Let's cut this!

@brancz
Copy link
Member

brancz commented Mar 15, 2019

Agreed. @mxinden you want to take care of this?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2019
@brancz
Copy link
Member

brancz commented Jun 13, 2019

v1.6.0 has already been released.

@brancz brancz closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants