-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for persistent volume claims accessmodes. #610
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Chenditang If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3ef524a
to
cb628e4
Compare
for _, a := range p.Status.AccessModes { | ||
f = append(f, | ||
&metrics.Metric{ | ||
LabelValues: []string{storageClassName, volumeName, string(v1.ReadWriteOnce)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mode should be a separate metric from the info metric.
21fd6ca
to
4e04b28
Compare
@brancz PTAL |
This lgtm, but we're currently in code freeze until we do the final release of the v1.5.0. Feel free to ping me if I don't come back to this myself once that release is out. |
I think we've gone way past the code freeze. Can this be rebased? @Chenditang |
@tariq1890 you're absolutely right. Thanks for following up. Happy to re-review once rebased. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This PR can be closed since #673 has been merged. /close |
@tariq1890: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add metric for persistent volume claims accessmodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #554