Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for persistent volume claims accessmodes. #610

Closed
wants to merge 1 commit into from

Conversation

Chenditang
Copy link

@Chenditang Chenditang commented Dec 4, 2018

What this PR does / why we need it:
Add metric for persistent volume claims accessmodes.

# HELP kube_persistentvolumeclaim_spec_accessmodes The accessmodes requested by the persistent volume claim.
# TYPE kube_persistentvolumeclaim_spec_accessmodes gauge
kube_persistentvolumeclaim_spec_accessmodes{namespace="default",persistentvolumeclaim="testpvc",accessmodes="ReadWriteOnce"} 0
kube_persistentvolumeclaim_spec_accessmodes{namespace="default",persistentvolumeclaim="testpvc",accessmodes="ReadOnlyMany"} 0
kube_persistentvolumeclaim_spec_accessmodes{namespace="default",persistentvolumeclaim="testpvc",accessmodes="ReadWriteMany"} 1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #554

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chenditang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andyxning

If they are not already assigned, you can assign the PR to them by writing /assign @andyxning in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2018
@Chenditang Chenditang force-pushed the pvc_accessmodes branch 2 times, most recently from 3ef524a to cb628e4 Compare December 5, 2018 03:55
for _, a := range p.Status.AccessModes {
f = append(f,
&metrics.Metric{
LabelValues: []string{storageClassName, volumeName, string(v1.ReadWriteOnce)},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mode should be a separate metric from the info metric.

@Chenditang Chenditang force-pushed the pvc_accessmodes branch 4 times, most recently from 21fd6ca to 4e04b28 Compare December 7, 2018 09:04
@Chenditang
Copy link
Author

@brancz PTAL

@brancz
Copy link
Member

brancz commented Dec 8, 2018

This lgtm, but we're currently in code freeze until we do the final release of the v1.5.0. Feel free to ping me if I don't come back to this myself once that release is out.

@tariq1890
Copy link
Contributor

I think we've gone way past the code freeze. Can this be rebased? @Chenditang

@brancz
Copy link
Member

brancz commented Mar 1, 2019

@tariq1890 you're absolutely right. Thanks for following up. Happy to re-review once rebased.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2019
@tariq1890
Copy link
Contributor

This PR can be closed since #673 has been merged.

/close

@k8s-ci-robot
Copy link
Contributor

@tariq1890: Closed this PR.

In response to this:

This PR can be closed since #673 has been merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metric for access mode for persistent volume claims
5 participants