Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label for priority class in kube_pod_info #712

Closed
sylr opened this issue Apr 4, 2019 · 4 comments
Closed

Add label for priority class in kube_pod_info #712

sylr opened this issue Apr 4, 2019 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sylr
Copy link
Contributor

sylr commented Apr 4, 2019 •
edited

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

It would be nice to be able to have information about the priority class to write alerts that does not involve low priority pods.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): 1.13.5
  • Kube-state-metrics 1.5.0
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2019
@brancz
Copy link
Member

brancz commented Apr 4, 2019

Priority class is flat information on the Pod object, so adding the label to kube_pod_info would be more appropriate I think, but generally I think this is a good idea to add.

@brancz brancz added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 4, 2019
@sylr sylr changed the title Add label for priority class in kube_pod_container_info Add label for priority class in kube_pod_info Apr 4, 2019
@chenk008
Copy link
Contributor

chenk008 commented Apr 4, 2019

@brancz Can I work on this?
/assign @chenk008

@k8s-ci-robot
Copy link
Contributor

@chenk008: GitHub didn't allow me to assign the following users: chenk008.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

@brancz Can I work on this?
/assign @chenk008

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz
Copy link
Member

brancz commented Apr 4, 2019

@chenk008 go for it! :)

chenk008 pushed a commit to chenk008/kube-state-metrics that referenced this issue Apr 4, 2019
Add label for priority class in kube_pod_info kubernetes#712
457821b
@chenk008 chenk008 mentioned this issue Apr 4, 2019
Merged
chenk008 added a commit to chenk008/kube-state-metrics that referenced this issue Apr 4, 2019
@chenk008
Add label for priority class in kube_pod_info kubernetes#712
56c45b3
k8s-ci-robot added a commit that referenced this issue Apr 5, 2019
@k8s-ci-robot
Merge pull request #713 from chenk008/add_priority_class_kube_pod_info
64b70f5 
Add label for priority class in kube_pod_info #712
paulfantom added a commit to paulfantom/kube-state-metrics that referenced this issue Jun 25, 2019
@paulfantom
Merge remote-tracking branch 'upstream/release-1.6' into release-1.6
d93a5d8 
* upstream/release-1.6: (90 commits)
  update documentation to reflect the latest release of kube-state-metrics
  *: Cut v1.6.0
  *: Cut v1.6.0-rc.2
  *: Cut v1.6.0-rc.1
  bump versions of prometheus,kubernetes, and addon-resizer
  use appsv1 apigroup for StatefulSets and DaemonSets
  use xenial dist in travis ci
  use a more idiomatic way of handling error messages
  fix: change the expectedType of the kube-client reflector to match the listWatch
  Add list/watch access to ClusterRole for CSR collector
  docs: minor improvements in kube-state-metrics README
  *: Cut v1.6.0
  README.md: Update compatibility matrix for kube-state-metrics v1.6
  pkg/metrics_store: Cache byte slices instead of strings
  internal/collector: Preallocate metric slice length when known upfront
  change unit test
  change unit test
  fmt unit test
  Add unit test Add “priority_class” in document
  Add label for priority class in kube_pod_info kubernetes#712
  ...
paulfantom added a commit to paulfantom/kube-state-metrics that referenced this issue Jun 26, 2019
@paulfantom
Merge remote-tracking branch 'upstream/release-1.6' into release-1.6
daef75f 
* upstream/release-1.6: (90 commits)
  update documentation to reflect the latest release of kube-state-metrics
  *: Cut v1.6.0
  *: Cut v1.6.0-rc.2
  *: Cut v1.6.0-rc.1
  bump versions of prometheus,kubernetes, and addon-resizer
  use appsv1 apigroup for StatefulSets and DaemonSets
  use xenial dist in travis ci
  use a more idiomatic way of handling error messages
  fix: change the expectedType of the kube-client reflector to match the listWatch
  Add list/watch access to ClusterRole for CSR collector
  docs: minor improvements in kube-state-metrics README
  *: Cut v1.6.0
  README.md: Update compatibility matrix for kube-state-metrics v1.6
  pkg/metrics_store: Cache byte slices instead of strings
  internal/collector: Preallocate metric slice length when known upfront
  change unit test
  change unit test
  fmt unit test
  Add unit test Add “priority_class” in document
  Add label for priority class in kube_pod_info kubernetes#712
  ...
paulfantom added a commit to paulfantom/kube-state-metrics that referenced this issue Jun 26, 2019
@paulfantom
Merge remote-tracking branch 'upstream/release-1.6' into release-1.6
0af7ecf 
* upstream/release-1.6: (90 commits)
  update documentation to reflect the latest release of kube-state-metrics
  *: Cut v1.6.0
  *: Cut v1.6.0-rc.2
  *: Cut v1.6.0-rc.1
  bump versions of prometheus,kubernetes, and addon-resizer
  use appsv1 apigroup for StatefulSets and DaemonSets
  use xenial dist in travis ci
  use a more idiomatic way of handling error messages
  fix: change the expectedType of the kube-client reflector to match the listWatch
  Add list/watch access to ClusterRole for CSR collector
  docs: minor improvements in kube-state-metrics README
  *: Cut v1.6.0
  README.md: Update compatibility matrix for kube-state-metrics v1.6
  pkg/metrics_store: Cache byte slices instead of strings
  internal/collector: Preallocate metric slice length when known upfront
  change unit test
  change unit test
  fmt unit test
  Add unit test Add “priority_class” in document
  Add label for priority class in kube_pod_info kubernetes#712
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sylr @chenk008 @brancz @k8s-ci-robot