Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated workload APIs due to it's removal in v1.16 #802

Closed
lilic opened this issue Jun 25, 2019 · 10 comments · Fixed by #804
Closed

Switch from deprecated workload APIs due to it's removal in v1.16 #802

lilic opened this issue Jun 25, 2019 · 10 comments · Fixed by #804

Comments

@lilic
Copy link
Member

lilic commented Jun 25, 2019

Currently, kube-state-metrics uses the deprecated extensions/v1beta1 workload APIs, but in v1.16 onwards these API are removed, so we should switch to the newer versions instead. This effects ingress and replicaset.

PR that removes it -> kubernetes/kubernetes#70672

@lilic
Copy link
Member Author

lilic commented Jun 25, 2019

Happy to make the needed changes. :)

@brancz
Copy link
Member

brancz commented Jun 25, 2019

Go ahead :)

@lilic
Copy link
Member Author

lilic commented Jun 25, 2019

@brancz Probably #796 release should happen before the above change?

@brancz
Copy link
Member

brancz commented Jun 25, 2019

How long as the networking API for the ingress replacement existed? If at least since kube 1.11 then I'm ok with having it in kube-state-metrics 1.7.

@qw1mb0
Copy link
Contributor

qw1mb0 commented Jun 26, 2019

This API is available only from 1.14: kubernetes/kubernetes#74057

@brancz
Copy link
Member

brancz commented Jun 26, 2019

Ok so the ingress one we'll need to keep until 1.18 then, but replicasets we can move now.

@tariq1890
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

@tariq1890: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tariq1890
Copy link
Contributor

tariq1890 commented Jun 26, 2019

@lilic I see that ingresses weren't included in this PR kubernetes/kubernetes#70672 and aren't slated to be removed.

So you are definitely right that it can be closed. Thanks for bringing it up.

@lilic
Copy link
Member Author

lilic commented Jun 26, 2019

@tariq1890 We can open a follow-up issue for switching from the deprecated ingress workloads API, so we remember to do that before the v1.18 release. If you think that will be of any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants