v2: Rename hpa metrics to use full horizontalpodautoscaler n… #1003

tlereste · 2019-12-13T15:10:55Z

What this PR does / why we need it:
Rename hpa metrics to use full horizontalpodautoscaler nomenclature for v2.0.0
Which issue(s) this PR fixes :
Fixes #977

tlereste · 2019-12-13T15:51:37Z

/retest

k8s-ci-robot · 2019-12-13T15:51:52Z

@tlereste: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

internal/store/horizontalpodautoscaler_test.go

tariq1890 · 2019-12-17T11:36:30Z

/hold

Putting on hold until the release of v1.9.0 .

tariq1890 · 2019-12-17T11:37:08Z

@tlereste Thank you for your PR. Can you squash your commits as well?

tlereste · 2019-12-17T12:20:49Z

@tlereste Thank you for your PR. Can you squash your commits as well?

Done !

lilic · 2020-01-31T09:53:20Z

@tlereste do you mind rebasing your PR, after that we can merge, thanks! :)

tlereste · 2020-01-31T15:28:10Z

@tlereste do you mind rebasing your PR, after that we can merge, thanks! :)

Ok thanks, rebase is done :)

lilic

One question to the maintainers otherwise 👍 Thanks!

internal/store/horizontalpodautoscaler.go

tariq1890 · 2020-01-31T20:11:12Z

internal/store/horizontalpodautoscaler.go

@@ -43,15 +43,15 @@ func (m MetricTargetType) String() string {
 }

 var (
-	descHorizontalPodAutoscalerLabelsName          = "kube_hpa_labels"
+	descHorizontalPodAutoscalerLabelsName          = "kube_horizontalpodautoscaler_labels"
 	descHorizontalPodAutoscalerLabelsHelp          = "Kubernetes labels converted to Prometheus labels."
 	descHorizontalPodAutoscalerLabelsDefaultLabels = []string{"namespace", "hpa"}


Suggested change

descHorizontalPodAutoscalerLabelsDefaultLabels = []string{"namespace", "hpa"}

descHorizontalPodAutoscalerLabelsDefaultLabels = []string{"namespace", "horizontalpodautoscaler"}

NOTE: Just highlighting the suggestion, I wouldn't suggest committing this suggestion. Can you change this manually?

Done. Can you let met rerun the tests please ?

tlereste · 2020-02-04T11:55:52Z

/retest

k8s-ci-robot · 2020-02-04T11:56:06Z

@tlereste: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tariq1890 · 2020-02-04T14:44:31Z

/ok-to-test

tlereste · 2020-02-04T14:46:34Z

/retest

tariq1890 · 2020-02-04T14:48:02Z

@tlereste Can you force push again? That should retrigger the tests.

lilic · 2020-02-04T14:58:12Z

I manually retriggered the job.

tariq1890

/lgtm

k8s-ci-robot · 2020-02-04T17:17:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tariq1890, tlereste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tariq1890 · 2020-02-04T17:36:15Z

/hold cancel

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2019

k8s-ci-robot requested review from andyxning and zouyee December 13, 2019 15:11

tlereste changed the title ~~Issue #977 - Rename hpa metrics to use full horizontalpodautoscaler n…~~ Rename hpa metrics to use full horizontalpodautoscaler n… Dec 13, 2019

tariq1890 changed the title ~~Rename hpa metrics to use full horizontalpodautoscaler n…~~ v2: Rename hpa metrics to use full horizontalpodautoscaler n… Dec 17, 2019

tariq1890 added the v2 version 2 label Dec 17, 2019

tariq1890 reviewed Dec 17, 2019

View reviewed changes

internal/store/horizontalpodautoscaler_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2019

tlereste force-pushed the issue_977 branch from 2ec9ea2 to c285576 Compare December 17, 2019 12:10

tlereste force-pushed the issue_977 branch from c285576 to 42a19de Compare January 2, 2020 13:15

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020

tlereste force-pushed the issue_977 branch from 42a19de to 1850d14 Compare January 31, 2020 14:43

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020

tlereste force-pushed the issue_977 branch from 1850d14 to 310e638 Compare January 31, 2020 15:07

lilic reviewed Jan 31, 2020

View reviewed changes

internal/store/horizontalpodautoscaler.go Outdated Show resolved Hide resolved

tlereste force-pushed the issue_977 branch from 310e638 to ed86005 Compare January 31, 2020 19:30

tariq1890 reviewed Jan 31, 2020

View reviewed changes

tlereste force-pushed the issue_977 branch from ed86005 to ea2ef83 Compare February 4, 2020 10:53

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 4, 2020

Rename hpa metrics to use full horizontalpodautoscaler nomenclature

eb01334

tlereste force-pushed the issue_977 branch from ea2ef83 to eb01334 Compare February 4, 2020 15:43

tariq1890 approved these changes Feb 4, 2020

View reviewed changes

k8s-ci-robot assigned tariq1890 Feb 4, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020

k8s-ci-robot merged commit 839da5e into kubernetes:master Feb 4, 2020

tlereste mentioned this pull request Apr 29, 2020

REQUEST: New membership for @tlereste kubernetes/org#1841

Closed

6 tasks

vsinghal13 mentioned this pull request Sep 29, 2020

rename hpa metrics SumoLogic/sumologic-kubernetes-collection#965

Merged

3 tasks

RemcodM mentioned this pull request Dec 23, 2020

[kubernetes_state] Metrics for HPA renamed in 2.x DataDog/integrations-core#8244

Closed

avivgold098 mentioned this pull request Jun 13, 2021

HPA metrics compatibility with kube-state-metrics v2.0+ kubernetes-monitoring/kubernetes-mixin#621

Closed

invidian mentioned this pull request Jul 8, 2021

Support KSM 2.0 #1526

Closed

debu99 mentioned this pull request Dec 6, 2021

Metrics for HPA renamed in 2.x samber/awesome-prometheus-alerts#266

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2: Rename hpa metrics to use full horizontalpodautoscaler n… #1003

v2: Rename hpa metrics to use full horizontalpodautoscaler n… #1003

tlereste commented Dec 13, 2019 •

edited

Loading

tlereste commented Dec 13, 2019

k8s-ci-robot commented Dec 13, 2019

tariq1890 commented Dec 17, 2019

tariq1890 commented Dec 17, 2019

tlereste commented Dec 17, 2019

lilic commented Jan 31, 2020

tlereste commented Jan 31, 2020

lilic left a comment

tariq1890 Jan 31, 2020

tariq1890 Jan 31, 2020 •

edited

Loading

tlereste Feb 4, 2020

tlereste commented Feb 4, 2020

k8s-ci-robot commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

tlereste commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

lilic commented Feb 4, 2020

tariq1890 left a comment

k8s-ci-robot commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

	descHorizontalPodAutoscalerLabelsDefaultLabels = []string{"namespace", "hpa"}
	descHorizontalPodAutoscalerLabelsDefaultLabels = []string{"namespace", "horizontalpodautoscaler"}

v2: Rename hpa metrics to use full horizontalpodautoscaler n… #1003

v2: Rename hpa metrics to use full horizontalpodautoscaler n… #1003

Conversation

tlereste commented Dec 13, 2019 • edited Loading

tlereste commented Dec 13, 2019

k8s-ci-robot commented Dec 13, 2019

tariq1890 commented Dec 17, 2019

tariq1890 commented Dec 17, 2019

tlereste commented Dec 17, 2019

lilic commented Jan 31, 2020

tlereste commented Jan 31, 2020

lilic left a comment

Choose a reason for hiding this comment

tariq1890 Jan 31, 2020

Choose a reason for hiding this comment

tariq1890 Jan 31, 2020 • edited Loading

Choose a reason for hiding this comment

tlereste Feb 4, 2020

Choose a reason for hiding this comment

tlereste commented Feb 4, 2020

k8s-ci-robot commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

tlereste commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

lilic commented Feb 4, 2020

tariq1890 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 4, 2020

tariq1890 commented Feb 4, 2020

tlereste commented Dec 13, 2019 •

edited

Loading

tariq1890 Jan 31, 2020 •

edited

Loading