*: Remove non-identifying labels from pod metrics #1009
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
internal/store/pod.go
Outdated
| @@ -57,8 +57,8 @@ var ( | |||
|
|
|||
| m := metric.Metric{ | |||
|
|
|||
| LabelKeys: []string{"host_ip", "pod_ip", "uid", "node", "created_by_kind", "created_by_name", "priority_class"}, | |||
| LabelValues: []string{p.Status.HostIP, p.Status.PodIP, string(p.UID), p.Spec.NodeName, createdByKind, createdByName, p.Spec.PriorityClassName}, | |||
| LabelKeys: []string{"host_ip", "pod_ip", "uid", "created_by_kind", "created_by_name", "priority_class"}, | |||
There was a problem hiding this comment.
This “info” type metric is ok to have it, just not all metrics. The idea is that any other metric can be easily joined with this one to add metadata when needed.
There was a problem hiding this comment.
@brancz thanks makes sense. So replacing here and removing from all other Pod metrics is sufficient?
There was a problem hiding this comment.
Yes I think so. I'll try and see if I can find any other cases in my review, but I believe this was all of them.
|
/hold until the current release is out |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm Nice! :) |
k8s-ci-robot
added
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@philipgough you need to fixup manually as bot is complaining it seems, do you mind merging all into one single commit, thanks!
|
Fixes kubernetes#979 test:store - Updates unit test to reflect removal of 'node' name from labels test: Update main_test for removal of node label from pod metrics
philipgough
force-pushed
the
fixes-979
branch
from
7edce00
to
58e7c50
Compare
k8s-ci-robot
removed
the
lgtm
|
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@lilic, sorry, this needed a rebase by the time I got around to it so might need another review. Squashed as requested. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
lilic
removed
the
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, LiliC, PhilipGough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixes #979
@lilic I made a start on this and I can't see anything else that I would consider "non-identifying" labels.
I also wondered about the removal of node name from metrics re cpu/mem usage, perhaps it is still valid there?