Rename black-/whitelist to allow/deny-list #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
During a bad rebase of #1002 my PR was closed, so I recreated this one. |
|
/assign @lilic |
lilic
reviewed
Feb 3, 2020
pkg/allowdenylist/allowdenylist.go
Outdated
| } | ||
|
|
||
| return "blacklisting the following items: " + strings.Join(items, ", ") | ||
| return "denylisting the following items: " + strings.Join(items, ", ") |
There was a problem hiding this comment.
hmm I would reword all the user facing strings to make it more readable, wdyt of something like:
Excluding the following lists that were on denylist: .....
pkg/allowdenylist/allowdenylist.go
Outdated
| if l.isWhiteList { | ||
| return "whitelisting the following items: " + strings.Join(items, ", ") | ||
| if l.isAllowList { | ||
| return "allowlisting the following items: " + strings.Join(items, ", ") |
There was a problem hiding this comment.
Same as below:
Including the following lists that were on allowlist: .....
tlereste
force-pushed
the
issue_975_with_author
branch
from
eef59f2
to
aa27e49
Compare
tlereste
force-pushed
the
issue_975_with_author
branch
from
aa27e49
to
cb65534
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiliC, tlereste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rename black-/whitelist to allow/deny-list for v2.0.0 release.
Which issue(s) this PR fixes :
Fixes #975