Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kube_replicationcontroller_owner #1058

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add kube_replicationcontroller_owner #1058

merged 1 commit into from
Feb 18, 2020

Conversation

olivierlemasle
Copy link
Member

What this PR does / why we need it:

Add metric for owner of ReplicationController - kube_replicationcontroller_owner

Which issue(s) this PR fixes:
Fixes #1055

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @olivierlemasle!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2020
@olivierlemasle olivierlemasle mentioned this pull request Feb 13, 2020
Closed
@olivierlemasle
Copy link
Member Author

/assign @tariq1890

lilic
lilic reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, few comments.

docs/replicationcontroller-metrics.md Outdated Show resolved Hide resolved
internal/store/replicationcontroller.go Outdated Show resolved Hide resolved
lilic
lilic reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do you mind squashing, then we can merge! 🎉 👍

@olivierlemasle
Copy link
Member Author

olivierlemasle commented Feb 18, 2020 •
edited
Loading

I've just squashed the commits and addressed @tariq1890's comment.

@tariq1890
Copy link
Contributor

Thanks @olivierlemasle :)!

tariq1890
tariq1890 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olivierlemasle, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3573269 into kubernetes:master Feb 18, 2020
@olivierlemasle olivierlemasle deleted the fix-1055 branch February 18, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@lilic lilic Awaiting requested review from lilic

Assignees

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metric for owner of ReplicationController - kube_replicationcontroller_owner
4 participants
@olivierlemasle @k8s-ci-robot @tariq1890 @lilic