-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various CI issues #1117
Fix various CI issues #1117
Conversation
This was most likely due to an issue on travis side, things are back to normal now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @brancz |
Fix various CI issues
What this PR does / why we need it:
CI caught a violation of the label name being
nodeName
(camelCase) rather than snake_case, however, this is actually a case of another violation, which is the kubernetes instrumentation guideline says, that this label should have always beennode
to begin with, to allow for joining without label_replace. This metric is experimental anyways, so we're free to change this.We're not sure yet why PR CI didn't catch this.Travis CI not reporting seems to have magically fixed itself (possibly by either @lilic or myself logging in to Travis refreshing something?).
To get CI into a working state, I fixed the remaining issues as well.
@lilic @tariq1890