-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod: Add init container requests #1123
Conversation
@@ -885,6 +885,64 @@ var ( | |||
} | |||
}), | |||
}, | |||
{ | |||
Name: "kube_pod_init_container_resource_requests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing entry in the docs for this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
} | ||
|
||
for _, metric := range ms { | ||
metric.LabelKeys = []string{"container", "resource", "unit"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start the discussion on the unit thing again? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now consistency is best. If we make a decision we will then apply it universally. I'm still undecided in either direction.
docs/pod-metrics.md
Outdated
@@ -34,6 +34,7 @@ | |||
| kube_pod_init_container_status_last_terminated_reason | Gauge | `container`=<container-name> <br> `pod`=<pod-name> <br> `namespace`=<pod-namespace> <br> `reason`=<OOMKilled\|Error\|Completed\|ContainerCannotRun\|DeadlineExceeded> | STABLE | | |||
| kube_pod_init_container_status_ready | Gauge | `container`=<container-name> <br> `pod`=<pod-name> <br> `namespace`=<pod-namespace> | STABLE | | |||
| kube_pod_init_container_status_restarts_total | Counter | `container`=<container-name> <br> `namespace`=<pod-namespace> <br> `pod`=<pod-name> | STABLE | | |||
| kube_pod_init_container_resource_requests | Gauge | `resource`=<resource-name> <br> `unit`=<resource-unit> <br> `container`=<container-name> <br> `pod`=<pod-name> <br> `namespace`=<pod-namespace> <br> `node`=< node-name> | STABLE | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's maintain lexical order here
Wow, can't believe we missed this :/ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could we have a new release with this feature? 🙏 |
What this PR does / why we need it:
In order to be able to calculate whether a pod can be scheduled, it's important to know what init containers request.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #1095
@lilic @tariq1890 @dgrisonnet