-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UnexpectedAdmissionError to kube_pod_status_reason metric #1145
add UnexpectedAdmissionError to kube_pod_status_reason metric #1145
Conversation
9132a0f
to
bdb2e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, can you link to where this Pod Status Reason is used in upstream k8s api, haven't been able to find it that well
Yes, kubelet report this reason |
In the cluster, it looks like this (kubernetes 1.16):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, qw1mb0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add
UnexpectedAdmissionError
reason tokube_pod_status_reason
metricWhich issue(s) this PR fixes:
Fixes #1114