add aws/gce volume id to kube_persistentvolume_info

[povilasv]

ref #704

[k8s-ci-robot]

Welcome @povilasv!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[povilasv]

/assign @brancz

[brancz]

Prometheus will drop the empty value anyways, so why the extra branch?

[povilasv]

👍 fixed. I'm not sure about empty keys, so I default key to default

[brancz]

Even the key doesn’t need to be conditional does it? We just add all of them always.

[povilasv]

Agreed, thanks for the tip. I did the change 👍

[brancz]

Very nice.

/lgtm
/approve

[povilasv]

CI was failing due to missing docs, so I have fixed it.

=== RUN   TestDocumentation
    TestDocumentation: main_test.go:133: Label gce_persistent_disk_name not found in documentation. Documented labels for metric kube_persistentvolume_info are: persistentvolume, storageclass
    TestDocumentation: main_test.go:133: Label ebs_volume_id not found in documentation. Documented labels for metric kube_persistentvolume_info are: persistentvolume, storageclass
--- FAIL: TestDocumentation (0.03s)

[brancz]

Isn't it lovely when tests work 😄

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, povilasv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brancz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[povilasv]

it is :D That doc test is pretty awesome.