add fc/iscsi/nfs identifier tags to persistentvolume_info

[jimmyseto]

What this PR does / why we need it:
export fc/iscsi/nfs info to help identify underlying storage

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[tariq1890]

Could you provide documentation/link to where these fields are defined?

[jimmyseto]

Could you provide documentation/link to where these fields are defined?

FC fields: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#fcvolumesource-v1-core
ISCSI fields: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#iscsipersistentvolumesource-v1-core
NFS fields: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#nfsvolumesource-v1-core

[tariq1890]

this needs to go under "context"

[tariq1890]

This needs to be resolved @jimmyseto

[jimmyseto]

Sorry about that @tariq1890 . The push was sitting at the login prompt. The PR should be updated now.

[tariq1890]

Thanks for this PR @jimmyseto

Can you also make sure these fields are supported in v1.14? That's the minimum version we should be supporting

[jimmyseto]

Thanks for this PR @jimmyseto

Can you also make sure these fields are supported in v1.14? That's the minimum version we should be supporting

Hi @tariq1890 -- Thanks for the quick response on this!

Confirmed that these fields are supported in v1.14.

FC fields: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#fcvolumesource-v1-core
ISCSI fields: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#iscsipersistentvolumesource-v1-core
NFS fields: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#nfsvolumesource-v1-core

Also, updated the PR to address your CR comments/feedback above.

Thanks, again.

[tariq1890]

Thanks very much @jimmyseto :)

[tariq1890]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmyseto, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jimmyseto]

@tariq1890 - do you know if there is a target date for the next official release?

[lilic]

@jimmyseto We have a release in progress, its a major breaking release so might take a few more days. #1224

[jimmyseto]

@jimmyseto We have a release in progress, its a major breaking release so might take a few more days. #1224

that's great, @lilic . thanks for the link!