Added the job failure reason in kube_job_status_failed metric #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
You can refer to the historic conversation - here |
|
/assign @tariq1890 |
dgrisonnet
reviewed
Sep 18, 2020
AdityaMisra
force-pushed
the
kube_metric_job_failed_reason
branch
from
c151ae2
to
056e934
Compare
AdityaMisra
force-pushed
the
kube_metric_job_failed_reason
branch
from
056e934
to
7979af8
Compare
Fixed linting issues Code review changes Removed condition label from kube_job_status_failed metric Removed condition label from Job Metrics
AdityaMisra
force-pushed
the
kube_metric_job_failed_reason
branch
from
7979af8
to
639b499
Compare
dgrisonnet
reviewed
Oct 12, 2020
|
This PR looks good from my side, @lilic can you please have another look at it? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AdityaMisra, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed linting issues
What this PR does / why we need it:
Added the job failure reason in kube_job_status_failed metric
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #947