Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golang-1.15.3 #1261

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Update to golang-1.15.3 #1261

merged 1 commit into from
Oct 15, 2020

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Oct 14, 2020 •
edited
Loading

What this PR does / why we need it:
Move to latest version of golang (1.15)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2020
@mrueg
Copy link
Member Author

mrueg commented Oct 14, 2020

/assign @tariq1890

@mrueg mrueg force-pushed the update-golang branch 2 times, most recently from b6b260a to 797e7ea Compare October 15, 2020 09:09
lilic
lilic reviewed Oct 15, 2020
View reviewed changes
Makefile Outdated
@@ -12,7 +12,7 @@ BuildDate = $(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
GIT_COMMIT ?= $(shell git rev-parse --short HEAD)
ALL_ARCH = amd64 arm arm64 ppc64le s390x
PKG = k8s.io/kube-state-metrics/v2/pkg
GO_VERSION = 1.14.7
GO_VERSION = 1.14.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind making the change to 1.15.3 all over the repo? Planned on doing the switch myself but since you opened the PR.

We have a few other places if you are willing to migrate to 1.15 :)
https://github.com/kubernetes/kube-state-metrics/blob/f1166b40298a6846a329f567d0d509d32ee45a81/.github/workflows/ci.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do!

@mrueg mrueg changed the title Makefile: Update to golang-1.14.9 Update to golang-1.15.3 Oct 15, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2020
lilic
lilic reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise 👍

go.mod
@@ -28,4 +28,4 @@ require (
k8s.io/klog/v2 v2.2.0
)

go 1.14
go 1.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as we are not using anything specific to go 1.15 so our users don't require to switch to 1.15, so should be compatible with 1.14.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed it!

lilic
lilic approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2cbd2e6 into kubernetes:master Oct 15, 2020
@mrueg mrueg mentioned this pull request Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@brancz brancz Awaiting requested review from brancz

Assignees

@tariq1890 tariq1890

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrueg @k8s-ci-robot @lilic @tariq1890