Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote v2.0.0 to beta pre-release #1322

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

lilic
Copy link
Member

@lilic lilic commented Dec 4, 2020

🎉 There were no bug reports around the functionality of the latest alpha releases, so we can now safely promote v2.0.0 to beta.

Next are scale and performance tests. If no major regressions are found, and no new bugs I would say we can cut a rc of v2.0.0. Unless any objections?

cc @brancz @tariq1890

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2020
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this! 🎉

@lilic
Copy link
Member Author

lilic commented Dec 4, 2020

Note we had one change since the last release but was not affecting users, not sure changing default image in examples makes sense to point out?

@lilic
Copy link
Member Author

lilic commented Dec 4, 2020

@brancz I need an lgtm label :D

@brancz
Copy link
Member

brancz commented Dec 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
Because we switched to default registry to gcr, but we are still using
quay for testing, we need to change default image name.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@lilic
Copy link
Member Author

lilic commented Dec 4, 2020

@brancz I had to make some adjustments to our e2e tests due to recent changes in default image in examples, see last commit. PTAL, thanks!

@brancz
Copy link
Member

brancz commented Dec 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit baacc7b into kubernetes:release-2.0 Dec 4, 2020
@lilic lilic deleted the promote-2.0-beta branch December 4, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants