-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build info metric #1332
Add build info metric #1332
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,6 +150,15 @@ http_request_duration_seconds_sum{handler="metrics",method="get"} 0.021113919999 | |
http_request_duration_seconds_count{handler="metrics",method="get"} 30 | ||
``` | ||
|
||
kube-state-metrics exposes the build info metric: | ||
``` | ||
kube_state_metrics_build_info{branch="master",goversion="go1.15.3",revision="6c9d775d",version="v2.0.0-beta"} 1 | ||
``` | ||
|
||
`kube_state_metrics_build_info` is used to expose version and other build information. For more usage about the info pattern, | ||
please check the blog post [here](https://www.robustperception.io/exposing-the-software-version-to-prometheus). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure we are allowed to link to external companies blog posts? Otherwise, agreed this blog is very useful! @brancz wdyt? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think there is a general rule here, if this was self-promotion I would be more critical, but here it's really just a helpful resource. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes sounds good, was on the edge. lgtm apart from the need to squash commits. |
||
|
||
|
||
### Scaling kube-state-metrics | ||
|
||
#### Resource recommendation | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would be good to add a few lines what those are useful for. Similiar to have we have them for the list and watch errors above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.