Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image tags #134

Merged
merged 1 commit into from
May 4, 2017
Merged

update image tags #134

merged 1 commit into from
May 4, 2017

Conversation

brancz
Copy link
Member

@brancz brancz commented May 3, 2017

We'll primarily distribute the kube-state-metrics container image via quay from now on as none of the kube-state-metrics maintainers have the ability to update the image on gcr (but we do for quay) and therefore it creates an unnecessary hassle when releasing.

@fabxc @mxinden @andyxning


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2017
@andyxning
Copy link
Member

I am upvoting that we need to find a better and easy way to distribute kube-state-metrics images. However, changing from gcr to quay seems to be a breaking change for user who has an assumption that all kubernetes main components should be available on gcr.

If we need to do the change, i suggest we make a statement about the transition in readme clearly. :)

@brancz brancz force-pushed the quay-dist branch 2 times, most recently from ca305a8 to 8a8deff Compare May 4, 2017 07:45
@zouyee
Copy link
Member

zouyee commented May 4, 2017

👍

@brancz brancz changed the title *: distribute kube-state-metrics via quay update image tags May 4, 2017
@brancz
Copy link
Member Author

brancz commented May 4, 2017

Google is planning to open up the release process so we'll keep the primary source to be gcr for now, so I just updated the tags now and will ping Google people to take care of publishing the image.

@fabxc
Copy link
Contributor

fabxc commented May 4, 2017

👍

@brancz brancz merged commit 701b6bb into kubernetes:master May 4, 2017
@brancz brancz deleted the quay-dist branch May 4, 2017 08:06
@cemo
Copy link

cemo commented May 5, 2017

It is still at not there. By the way why docker hub is not considered in the first place?

@brancz
Copy link
Member Author

brancz commented May 5, 2017

We've always distributed the image via gcr, it was the default when the project started as it is the natural choice for a somewhat google scoped project. FWIW we (CoreOS) are also maintaining images of kube-state-metrics hosted on quay.io, that already has the v0.5.0 image. https://quay.io/repository/coreos/kube-state-metrics?tag=latest&tab=tags

Other than that Google has a goal of opening up the release process for the Kubernetes 1.7 release, which is supposedly going to allow us to get the images up more quickly. The current process is to release and wait for Googlers to upload the image.

while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants