-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Kubernetes recommande labels #1387
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nlamirault The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your contribution! |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }} | ||
app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
app.kubernetes.io/instance: {{ .Release.Name }} | ||
app: {{ template "kube-state-metrics.name" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this lone app:
label (not as part of templates) seems inconsistent to me. Why not add this app:
label through .Values.customLabels
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do that to be consistent with other charts (Like : https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/prometheus/clusterrolebinding.yaml#L7).
Do you want i remove it and use customLabels ?
* master: (50 commits) RELEASE.md: Add missing bits to the release workflow update RBAC manifests to v1 Regenerate cli docs Cut 2.0.0-rc.1 Rename cli flag from label-metrics-allow-list to metric-labels-allowlist Fix docs README link to a nonexistent section cli-arguments.md: Fix docs go.mod: Update dependencies Makefile: Use promtool 2.25.2 Make/Dockerfile: Switch to 1.16 OWNERS: Add mrueg as reviewer examples: regenerate jsonnet/kube-state-metrics/kube-state-metrics.libsonnet: Remove old API internal/store/verticalpodautoscaler_test.go: Switch test to new API Update latest 1.9 version to 1.9.8 in README.md [Backport] Remove vendor directory cli-arguments.md: Fix docs go.mod: Update dependencies Make/Dockerfile: Switch to 1.16 Combine 4-into-1 ... Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Thanks for your contribution. We moved our helm charts to https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics Feel free to reopen a PR on https://github.com/prometheus-community/helm-charts/ ! |
Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com
What this PR does / why we need it:
Add Kubernetes recommanded labels https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Ex:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Output :