-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding customLabels value to all available resources #1441
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @jaredclarke! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaredclarke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I signed it |
e4a2d4d
to
8c2e43b
Compare
/hold |
Thanks for your contribution. We moved our helm charts to https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics Feel free to reopen a PR on https://github.com/prometheus-community/helm-charts/ ! |
What this PR does / why we need it:
This PR extends the customLabels value into all resources.
We run a set of OPA tests with one of them being standard labelling across all resources that support labels.