Fix builder.Builder WithMetrics signature

[L3n41c]

What this PR does / why we need it:

The WithMetrics method signature changed from

func (b *Builder) WithMetrics(r *prometheus.Registry) {

to

func (b *Builder) WithMetrics(r prometheus.Registerer) {

in #1223 but one occurrence was forgotten.

Which issue(s) this PR fixes

Fixes the following compilation error when kube-state-metrics is used as a GO dependency of an external project:

	*builder.Builder does not implement "k8s.io/kube-state-metrics/v2/pkg/builder/types".BuilderInterface (wrong type for WithMetrics method)
		have WithMetrics(*prometheus.Registry)
		want WithMetrics(prometheus.Registerer)

[k8s-ci-robot]

Welcome @L3n41c!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[L3n41c]

/assign @tariq1890

[tariq1890]

/lgtm

Thanks! @L3n41c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: L3n41c, mrueg, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilic]

Thank you! We should backport this to release-2.0 as I suspect it has the same problem?

[L3n41c]

@lilic Thanks for bringing the backport point to my attention.
I’ve just opened #1459 to cherry-pick the commit of this PR to branche release-2.0. Is this the right thing to do ?