-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut v2.1.0-rc.0 #1483
Cut v2.1.0-rc.0 #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
| **v1.9.8** | - | - | - | - | - | | ||
| **v2.0.0** | -/✓ | -/✓ | ✓ | ✓ | -/✓ | | ||
| **v2.1.0-rc.0** | -/✓ | -/✓ | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need an rc, we can go straight to the release of v2.1, we mainly did this for 2.0 due to so many breaking changes. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me as well, I did it as the release process suggested to start with an rc. I don't mind going straight to 2.1.0 and branch off then. the risk should be rather low.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still follow the documented release process.
But having said that, if we want to retire the rc builds, I am okay with amending the release process in another PR and going forward with this approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned I am happy with going with releases candidates 👍
error: pathspec 'release-2.1' did not match any file(s) known to git
You need to create a new release branch, do you have permissions for it?
I was following the release steps (to ensure they are correct). I can create a branch here for the release from master. I assume we need to do that first then? |
Yeah, it's not a common step, but the benchmark test requires it.
guess it's an odd ordering but its in the release docs. |
I pushed the release-2.1 branch and switched this PR to point to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
@lilic @tariq1890 @brancz