persistentvolumeclaim: Implement annotation and fix label metrics generation

[arajkumar]

What this PR does / why we need it:

Implementation of kube_persistentvolumeclaim_labels was accidentally removed after #1468. This PR add it back with proper unit test.

This PR also implements kube_persistentvolumeclaim_annotations.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

N/A

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com

[k8s-ci-robot]

Welcome @arajkumar!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[fpetkovski]

Thanks for the contribution @arajkumar. Could you expand the PR description with an explanation of the regression?

[arajkumar]

Thanks for the contribution @arajkumar. Could you expand the PR description with an explanation of the regression?

I've amended the PR description. Please check.

[fpetkovski]

Thanks for providing the additional context 👍

/lgtm

[mrueg]

/lgtm

Thanks for catching that

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, fpetkovski, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment