Add the "--opt-in-metrics" argument to the CLI to allow for opt-in metrics #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-in metric family (kubernetes#1574)
k8s-ci-robot
added
cncf-cla: yes
|
I noticed the CI checks and will resolve them this evening! |
mrueg
reviewed
Nov 29, 2021
Serializator
force-pushed
the
feature/opt-in-metrics-1574
branch
4 times, most recently
from
f8d3b74
to
dab4a39
Compare
fpetkovski
reviewed
Nov 30, 2021
Serializator
force-pushed
the
feature/opt-in-metrics-1574
branch
2 times, most recently
from
8a95d3e
to
df1e058
Compare
|
Nice work! /hold for @mrueg to take another look |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
mrueg
reviewed
Dec 1, 2021
…ly from the store (kubernetes#1574)
Serializator
force-pushed
the
feature/opt-in-metrics-1574
branch
from
df1e058
to
da04a73
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It introduces a way of defining metrics as "opt-in", meaning the end-user needs to specifically specify that metrics which are marked as "opt-in" are to be exposed by the store.
--opt-in-metricsis used to specify which opt-in metrics to expose from the store. It follows the same notation as the--metric-allowlistand--metric-denylistarguments.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
It does not directly change or affect the cardinality of existing metrics.
Which issue(s) this PR fixes:
Fixes #1574