Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update client-go version in readme #191

Merged

Conversation

andyxning
Copy link
Member

@andyxning andyxning commented Jul 31, 2017

Fix #185

It's my fault not updating client-go version to v4.0.0-beta.0 in readme in #185. This PR updates the version info about client-go to v4.0.0-beta.0 in Readme.

/cc @brancz @fabxc


This change is Reviewable

@brancz
Copy link
Member

brancz commented Jul 31, 2017

I actually thought it was intentional 🙂 . I'll merge this once we kick off the release process for the next release. Thanks for following up!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@brancz
Copy link
Member

brancz commented Aug 2, 2017

Actually I'm afraid we might forget it, so I'd rather merge now. 🙂

lgtm

@brancz brancz merged commit 3031b62 into kubernetes:master Aug 2, 2017
@andyxning andyxning deleted the update_client-go_version_in_readme branch August 2, 2017 10:36
while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018
…sion_in_readme

update client-go version in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants