Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add status badge for the periodic cronjob #1924

Merged
merged 1 commit into from
Dec 10, 2022
Merged

docs: add status badge for the periodic cronjob #1924

merged 1 commit into from
Dec 10, 2022

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Dec 5, 2022

Additionally, rename it to a more fitting name.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2022
@mrueg
Copy link
Member

mrueg commented Dec 5, 2022

/triage accept
/hold
/lgtm

@k8s-ci-robot
Copy link
Contributor

@mrueg: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept
/hold
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2022
olivierlemasle
olivierlemasle reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you might take advantage of this change to update the GoDoc reference.

README.md Outdated Show resolved Hide resolved
@CatherineF-dev
Copy link
Contributor

/lgtm

@olivierlemasle
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 7, 2022
@rexagod
docs: add status badge for the periodic cronjob
2849d59 
Additionally, rename it to a more fitting name.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2022
@mrueg
Copy link
Member

mrueg commented Dec 10, 2022

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, mrueg, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f01ce58 into kubernetes:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlemasle olivierlemasle olivierlemasle left review comments

@CatherineF-dev CatherineF-dev CatherineF-dev left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@mrueg mrueg

@CatherineF-dev CatherineF-dev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rexagod @mrueg @k8s-ci-robot @CatherineF-dev @olivierlemasle @dgrisonnet