-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich UserAgent with more information #1960
Conversation
Before: "User-Agent: v2.7.0" After: "User-Agent: kube-state-metrics/v2.7.0 (linux/amd64) kubernetes/1cda0bf9"
the version, gitcommit, etc. gets added via ldflags in https://github.com/kubernetes/kube-state-metrics/blob/main/Makefile#L64 Likely that's why it can't be resolved in your IDE |
Ah, right! 🤦🏼 |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Before:
"User-Agent: v2.7.0"
After:
"User-Agent: kube-state-metrics/v2.7.0 (linux/amd64) kubernetes/1cda0bf9"
This mimicks restclient.DefaultKubernetesUserAgent()
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1955