Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting #1938 to 2.3 #1961

Conversation

ryanrolds
Copy link
Contributor

@ryanrolds ryanrolds commented Jan 24, 2023

What this PR does / why we need it:

Backports #1938 to the 2.3 release branch. We are in process of updating our K8s cluster, but current OKRs require tracking these metrics sooner rather than later. Happy to backport to all release branches from 2.3 on.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

It shouldn't affect it beyond what is already in the main branch.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ryanrolds
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval by writing /assign @dgrisonnet in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2023
@mrueg
Copy link
Member

mrueg commented Jan 24, 2023

We consider new metrics a new feature and therefore would like to limit backporting to bug and security vulnerability fixes only.

@ryanrolds
Copy link
Contributor Author

Makes sense. Thanks.

@ryanrolds ryanrolds closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants