build: Build with go 1.20.1 #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
mrueg
force-pushed
the
go-1.20
branch
3 times, most recently
from
7a91958
to
9d5a95a
Compare
k8s-ci-robot
added
size/L
mrueg
force-pushed
the
go-1.20
branch
2 times, most recently
from
64ff423
to
284f346
Compare
|
@dgrisonnet can you take a look if you got some spare cycles? |
k8s-ci-robot
added
the
needs-rebase
|
@mrueg sorry for the delay, I can have a look at the PR once it is rebased |
Also bump prometheus and golang dependencies Signed-off-by: Manuel Rüger <manuel@rueg.eu>
k8s-ci-robot
removed
the
needs-rebase
|
@dgrisonnet it's rebased now |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumps to go 1.20.x
Also bump prometheus and golangci-lint
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #