Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label resolution for maps #2007

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix label resolution for maps #2007

merged 1 commit into from
Feb 23, 2023

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 22, 2023 •
edited
Loading

What this PR does / why we need it: The map[string]interface{} resolution searched for values within various nested fields, but not the relative path itself.

How does this change affect the cardinality of KSM: No change.

kube-state-metrics/pkg/customresourcestate/registry_factory.go

Lines 598 to 604 in ca1da6b

} else {
out = append(out, pathOp{
part: part,
op: func(m interface{}) interface{} {
if mp, ok := m.(map[string]interface{}); ok {
return mp[part]
} else if s, ok := m.([]interface{}); ok {

@rexagod
Fix label resolution for maps
3f0532b 
The `map[string]interface{}` resolution searched for values within various nested fields, but not the relative path itself.

Ref.: https://github.com/kubernetes/kube-state-metrics/blob/ca1da6b22ed28fe3aa6cac98705cff71c614eac0/pkg/customresourcestate/registry_factory.go#L603

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
logicalhan
logicalhan approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a7e617 into kubernetes:main Feb 23, 2023
@rexagod rexagod mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexagod @k8s-ci-robot @logicalhan