feat!: Remove VerticalPodAutoscaler #2017
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
needs-rebase
internal/store/networkpolicy_test.go
Outdated
| # HELP kube_networkpolicy_labels Kubernetes labels converted to Prometheus labels. | ||
| # TYPE kube_networkpolicy_labels gauge |
There was a problem hiding this comment.
is it just me or that is a bit sus?
Ah I see, it is unused. Normally you would have that on top of tests were you have headers in commons and want to simplify the header verificaiton as in: https://github.com/kubernetes/kube-state-metrics/blob/80e67d01a20f1a16147d8acb4d474a46ccc4971b/internal/store/certificatesigningrequest_test.go
let's remove it for now and fix it in a follow up?
There was a problem hiding this comment.
I found it while I was looking for vpa/verticalpodautoscaler and thought this will improve it at least a bit. I can drop it.
There was a problem hiding this comment.
it doesn't seem to be used right, so I am with either add the logic to use it in this PR as in
or drop it and do it in a follow-upThere was a problem hiding this comment.
Sounds good, I dropped it for now.
docs/customresourcestate-metrics.md
Outdated
|
|
||
| ```yaml | ||
| # Using --resource=verticalpodautoscalers, we get the following output: | ||
| # HELP kube_verticalpodautoscaler_annotations (Deprecated since v2.9.0) Kubernetes annotations converted to Prometheus labels. |
There was a problem hiding this comment.
wasn't this deprecated since v2.7.0?
There was a problem hiding this comment.
Good catch, this was a copy'n'paste issue.
BREAKING CHANGE: VPA is now supported only via Custom Resource Metrics Signed-off-by: Manuel Rüger <manuel@rueg.eu>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Guys, I believe you should make a major release (3.0) when you are making such big changes. |
What this PR does / why we need it:
BREAKING CHANGE: VPA is now supported only via Custom Resource Metrics
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Removes a resource
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1790