Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for PodSecurity restricted #2042

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add parameters for PodSecurity restricted #2042

merged 1 commit into from
Apr 11, 2023

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Apr 5, 2023

What this PR does / why we need it:

This sets the pod security elements to be compatible with PodSecurity restricted

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Does not change

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jcpunk!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 6, 2023
@dgrisonnet
Copy link
Member

Hi @jcpunk, thank you for the contribution.

Could you please regenerate the examples by running make examples and commit the file changes?

@jcpunk
Copy link
Contributor Author

jcpunk commented Apr 7, 2023

How do I get gojsontoyaml?

$ make examples
mkdir -p examples/standard
jsonnet -J scripts/vendor -m examples/standard --ext-str version="2.8.2" scripts/standard.jsonnet | xargs -I{} sh -c 'cat {} | gojsontoyaml > `echo {} | sed "s/\(.\)\([A-Z]\)/\1-\2/g" | tr "[:upper:]" "[:lower:]"`.yaml' -- {}
--: line 1: gojsontoyaml: command not found
--: line 1: gojsontoyaml: command not found
--: line 1: gojsontoyaml: command not found
--: line 1: gojsontoyaml: command not found
--: line 1: gojsontoyaml: command not found
make: *** [Makefile:141: examples/standard] Error 123
[riehecky@leibniz kube-state-metrics]$ yum provides */gojsontoyaml
Last metadata expiration check: 1 day, 20:20:16 ago on Wed 05 Apr 2023 03:51:38 PM CDT.
Error: No matches found.

@mrueg
Copy link
Member

mrueg commented Apr 11, 2023

You can run make install-tools, see: https://github.com/kubernetes/kube-state-metrics/blob/main/Makefile#L157

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2023
@jcpunk
Copy link
Contributor Author

jcpunk commented Apr 11, 2023

In theory, these are updated now.

@mrueg
Copy link
Member

mrueg commented Apr 11, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpunk, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@mrueg
Copy link
Member

mrueg commented Apr 11, 2023

Thanks for your contribution!

@k8s-ci-robot k8s-ci-robot merged commit e3d99ba into kubernetes:main Apr 11, 2023
@jcpunk jcpunk deleted the pss-restricted branch April 11, 2023 16:02
@rexagod rexagod mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants