Fix casing while scraping failure reason for kube_job_status_failed

[juanjjaramillo]

What this PR does / why we need it:
When scraping the failure reason for a job, KSM does a case-sensitive search for the keyword DeadLineExceeded. Since Kubernetes is generating the string DeadlineExceeded, the search fails to scrape the reason. This PR proposes to do a case-insensitive search instead, so changes in casing do not affect the scraping of the reason.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change cardinality

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2045

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: juanjjaramillo / name: Juan Jose Jaramillo (2990fd5)

[k8s-ci-robot]

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @juanjjaramillo!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[CatherineF-dev]

This metric is a stable metric. https://github.com/kubernetes/kube-state-metrics/blob/main/docs/job-metrics.md

Changing this might break alerts using this reason.

cc @dgrisonnet do we allow this change for stable metrics?

[mrueg]

Was it ever DeadLineExceeded in upstream kubernetes? If not this seems like a bug in kubestatemetrics

[dgrisonnet]

Yes this is a bug, I believe it was always DeadlineExceeded, but we might have made a typo when introducing the change.

@juanjjaramillo could you perhaps also update the value in https://github.com/kubernetes/kube-state-metrics/blob/main/internal/store/job.go#L42?

[dgrisonnet]

@CatherineF-dev yes we do. It is very rare that label value changes are breaking changes and even if they are I think we should always go forward with them, but if there is any doubt, we should always call the change out in the changelog/release note.

Moreover in this particular case it fixes an actual bug that prevent the actual reason to be exposed, so we should definitely fix it.

[dgrisonnet]

We want to map the value exactly to make sure that we have a bounded list of potential values, so I don't think we should make that case insensitive. We should rather update the list of reasons and make sure we are more careful in the future to avoid these kind of typos.

[juanjjaramillo]

Makes sense @dgrisonnet

I have already undo this change. Casing in https://github.com/kubernetes/kube-state-metrics/blob/main/internal/store/job.go#L42 was already part of the previous commit, so I only needed to update unit testing to make tests pass. Please let me know if something else is needed.

Thank you for the review!

[dgrisonnet]

Thank you @juanjjaramillo! :)

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, juanjjaramillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgrisonnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment