feat(pv): support kube_persistentvolume_deletion_timestamp #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-triage
mrueg
reviewed
May 22, 2023
dgrisonnet
reviewed
Jun 5, 2023
maxime1907
force-pushed
the
featpvdeletiontimestamp
branch
2 times, most recently
from
bed36a5
to
3fedfd2
Compare
dgrisonnet
reviewed
Jun 14, 2023
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
maxime1907
force-pushed
the
featpvdeletiontimestamp
branch
from
3fedfd2
to
2be0d9e
Compare
|
any update on this ? @mrueg @dgrisonnet |
|
/lgtm Apologies for the delay, thanks for your contribution! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxime1907, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a simple metric
kube_persistentvolume_deletion_timestampso that we can detect PVs in "Terminating" stateHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases