Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add webhooks client config service metrics #2114

Merged
merged 1 commit into from
Jul 26, 2023

Commits on Jul 4, 2023

  1. *: add webhooks client config service metrics

    In order to better identify, prioritize, and debug webhook latency
    issues it is important to have a metric that would point to the resource
    it is responsible for.  However, it is not possible to have that
    dimension in the metrics exposed by Kubernetes because of the unbound
    cardinality that such a label would have.
    
    The name of the webhook could be an alternative since it usually
    contains some information about the resource that the webhook targets,
    however this is not very practical to use in multi-tenants
    environments.
    
    A solution for these kind of platform is to tie a specific webhook to a
    namespace in order to be able to know which tenant manages it and take
    actions depending on that. This is achieveable by leveraging the client
    config information of webhooks configured via WebhookConfiguration
    resources since Services are namespaced objects.
    
    With these new metrics, users will be able to split the alerting
    severity of webhook latency / rejection rate per namespace on top of
    being able to do it based on the webhook name. This is key in
    environment where administrators don't have control over the webhooks
    installed by the various tenants.
    
    Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
    dgrisonnet committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    229befd View commit details
    Browse the repository at this point in the history