Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut 1.0 #213

Merged
merged 1 commit into from
Aug 9, 2017
Merged

*: cut 1.0 #213

merged 1 commit into from
Aug 9, 2017

Conversation

brancz
Copy link
Member

@brancz brancz commented Aug 8, 2017

As we haven't had any bug reports or code changes over the past week, here goes the final 1.0 release.

As I'm a bit short on time today, but wanted to get this out there I already marked the date to be tomorrow as I'm not planing on finishing the release today, but giving everyone the chance to review once more over night/day around the globe.

🎉 It's happening 🎉

@fabxc @matthiasr @piosz @loburm @andyxning

I'll synchronize with @loburm tomorrow to make sure we have the container images online at the point where we merge this.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2017
@andyxning
Copy link
Member

IMO, the change log should be appended instead of modifing an existing item. How about we append a 1.0 release note instead.

@piosz
Copy link
Member

piosz commented Aug 9, 2017

+1 for appending
Otherwise LGTM

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

Fine with appending, should I repeat the entire changelog again since v0.5.0?

@andyxning
Copy link
Member

andyxning commented Aug 9, 2017

Just looked at kubernetes changelog, it is fine to repeat with all alpha/beta release changelog in newer GA release since the latest GA release one.

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

@piosz @andyxning adapted.

@andyxning
Copy link
Member

SGTM

Copy link

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kubernetes changelog states "changes since" because there are release branches that receive updates. Personally I would make rc1 disappear from the changelog since there are now two basically identical entries, but I'm fine with releasing it either way.

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

I don't have a particularly strong opinion on either side, I think it's worth nothing that there was a release candidate, but it does also look odd that there are two identical entries. I guess this way we sort of satisfy everyone.

@piosz
Copy link
Member

piosz commented Aug 9, 2017

Were there any changes between rc1 and 1.0? If not can we just have an empty change log for 1.0?
What I had in mind is that I don't like "erasing" history.

IIUC the changes are "since the last release" so copying all of them doesn't make sense IMO.

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

Also fine by me. That way we can explicitly state that there were no bugs found or other changes.

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

How does this look/sound to everyone?

Copy link

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@andyxning
Copy link
Member

Incremental change log is ok to me. :)

@piosz
Copy link
Member

piosz commented Aug 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2017
@brancz brancz merged commit 259497e into master Aug 9, 2017
@brancz brancz deleted the cut-1.0 branch August 9, 2017 10:49
@andyxning
Copy link
Member

What about the image status?

@loburm
Copy link
Contributor

loburm commented Aug 9, 2017

image was pushed to google-containers

@brancz
Copy link
Member Author

brancz commented Aug 9, 2017

For those who are wondering, the images are available here:

  • gcr.io/google_containers/kube-state-metrics:v1.0.0
  • quay.io/kubernetes/kube-state-metrics:v1.0.0

I'll make sure to include those starting with the next release in the GitHub releases. I always make sure the images are online before I publish the GitHub release. Thanks @loburm for taking care of the gcr image!

while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants