-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: cut 1.0 #213
*: cut 1.0 #213
Conversation
IMO, the change log should be appended instead of modifing an existing item. How about we append a 1.0 release note instead. |
+1 for appending |
Fine with appending, should I repeat the entire changelog again since |
Just looked at kubernetes changelog, it is fine to repeat with all alpha/beta release changelog in newer GA release since the latest GA release one. |
@piosz @andyxning adapted. |
SGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kubernetes changelog states "changes since" because there are release branches that receive updates. Personally I would make rc1 disappear from the changelog since there are now two basically identical entries, but I'm fine with releasing it either way.
I don't have a particularly strong opinion on either side, I think it's worth nothing that there was a release candidate, but it does also look odd that there are two identical entries. I guess this way we sort of satisfy everyone. |
Were there any changes between rc1 and 1.0? If not can we just have an empty change log for 1.0? IIUC the changes are "since the last release" so copying all of them doesn't make sense IMO. |
Also fine by me. That way we can explicitly state that there were no bugs found or other changes. |
How does this look/sound to everyone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Incremental change log is ok to me. :) |
/lgtm |
What about the image status? |
image was pushed to google-containers |
For those who are wondering, the images are available here:
I'll make sure to include those starting with the next release in the GitHub releases. I always make sure the images are online before I publish the GitHub release. Thanks @loburm for taking care of the gcr image! |
As we haven't had any bug reports or code changes over the past week, here goes the final 1.0 release.
As I'm a bit short on time today, but wanted to get this out there I already marked the date to be tomorrow as I'm not planing on finishing the release today, but giving everyone the chance to review once more over night/day around the globe.
🎉 It's happening 🎉
@fabxc @matthiasr @piosz @loburm @andyxning
I'll synchronize with @loburm tomorrow to make sure we have the container images online at the point where we merge this.
This change is