-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce Markdown linter and formatter #2184
feat: introduce Markdown linter and formatter #2184
Conversation
700766b
to
efc5dce
Compare
efc5dce
to
d14d661
Compare
d14d661
to
3efe474
Compare
Thanks, this is looking good! Two things from my side:
|
3efe474
to
fadb8b3
Compare
Hi, @mrueg
According to this document, it's possible to use
Linter to Markdown is called in
|
/triage accepted |
Thanks, a small couple of nits in the Makefile. Other than that looks good to me. |
Thank you for your suggestions! |
9093d90
to
81e825d
Compare
/lgtm Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, opeco17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR introduces markdownlint-cli2, the linter and formatter for Markdown files.
make lint
will be able to check the format of Markdown files andmake lint-fix
fix them.Since some rules can't be fixed by
markdownlint-cli2
automatically, I've disabled those rules temporarily.They should be enabled one by one once it's fixed.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
does not change cardinality
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2178