Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cut v2.10.1 #2192

Merged
merged 4 commits into from
Sep 18, 2023
Merged

chore: Cut v2.10.1 #2192

merged 4 commits into from
Sep 18, 2023

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 12, 2023 •
edited
Loading

What this PR does / why we need it: v2.10.1 release prep.

## v2.10.1 / 2023-09-13

### Note
- This release addresses a regression introduced in https://github.com/kubernetes/kube-state-metrics/pull/2105.

* [BUGFIX] Remove FieldSelector from non-namespaced resources by @mrueg and @dgrisonnet in https://github.com/kubernetes/kube-state-metrics/pull/2190

TODOs

  • Release v2.10.1.
  • kpromo changes.

mrueg and others added 2 commits September 13, 2023 00:27
@mrueg @rexagod
Fix: Remove FieldSelector from non-namespaced resources
9e55d96 
This should resolve the issue with namespace-denylist as discovered in kubernetes#2187

Regression introduced in kubernetes@c3c5528

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@dgrisonnet @rexagod
store: fix missing cluster-scoped resources
4482e2d 
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
@rexagod
Copy link
Member Author

rexagod commented Sep 12, 2023

/cc @dgrisonnet

@rexagod
Copy link
Member Author

rexagod commented Sep 12, 2023

I missed updating Go to 1.20.8 to address certain CVEs, on it.

@rexagod rexagod force-pushed the prep-v2.10.1 branch 2 times, most recently from 48a0659 to bcaf2c7 Compare September 12, 2023 20:57
@dgrisonnet
Copy link
Member

@rexagod could you mention the go update in the changelog please?

@rexagod
Bump Go to v1.20.8
7371474 
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
chore: Cut v2.10.1
1a59246 
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
dgrisonnet
dgrisonnet approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d68bad2 into kubernetes:release-2.10 Sep 18, 2023
14 checks passed
@dgrisonnet dgrisonnet mentioned this pull request Oct 5, 2023
Closed
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Oct 8, 2023
@rexagod
Revert "Merge pull request kubernetes#2192 from rexagod/prep-v2.10.1"
abf59a9 
This reverts commit d68bad2, reversing
changes made to 25fb4fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@CatherineF-dev CatherineF-dev Awaiting requested review from CatherineF-dev

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rexagod @k8s-ci-robot @dgrisonnet @mrueg