feat: add kube_node_status_addresses metric

[stonith]

What this PR does / why we need it:
Adds kube_node_status_addresses metric to account for mutiple addresses per type.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds a new metric per node

[k8s-ci-robot]

Welcome @stonith!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[dgrisonnet]

/assign @rexagod
/triage accepted

[stonith]

Seems to work as expected in a dualstack GKE cluster:

kube_node_info{node="gke-dualstack-test-default-pool-b7e9ab8b-q7g4",kernel_version="5.15.109+",os_image="Container-Optimized OS from Google",container_runtime_version="containerd://1.7.0",kubelet_version="v1.27.3-gke.100",kubeproxy_version="v1.27.3-gke.100",provider_id="gce://test/us-west1-a/gke-dualstack-test-default-pool-b7e9ab8b-q7g4",pod_cidr="10.84.0.0/24",system_uuid="c880482c-39d8-8523-70de-0658b88a5fe6",internal_ip="10.0.0.3",internal_ip="2600:1900:4040:203:0:0:0:0",external_ip="35.203.180.214"} 1

[dgrisonnet]

I am not a fan of adding labels to the _info metric. Most of them are legacy and should be in their own metric. Ideally we should address that in the next major version since they are all marked as stable.

It would be better to have a dedicated kube_node_status_addresses metric instead with type and ip labels. @stonith could you introduce this new metric instead of adding the new label?

@mrueg interested about your opinion on this

[dgrisonnet]

Ah well I just saw #2252 (comment), I guess our opinion align then 😆

[mrueg]

Yep, the kube_node_status_addresses would be my preference. Also I don't think prometheus allows to have the same label multiple times.

Ideally it would look like this and we'll keep internal_ip still in there with a TODO to kill it in ksm-3.x

kube_node_status_address{type="internal", address="1.2.3.4"} 1
kube_node_status_address{type="internal", address="1::2"} 1
kube_node_status_address{type="external", address="2.3.4.5"} 1
kube_node_status_address{type="external", address="3::4"} 1
kube_node_status_address{type="hostname", address="example.com"} 1

[stonith]

Updated PR to add kube_node_status_address metric

[mrueg]

This looks good to me, two small requests:

• Can you add a comment to the _info metric e.g.// TODO: remove internal_ip in v3, replaced by kube_node_status_address ?
• Can you update the metrics documentation?

[stonith]

This looks good to me, two small requests:

• Can you add a comment to the _info metric e.g.// TODO: remove internal_ip in v3, replaced by kube_node_status_address ?
• Can you update the metrics documentation?

• Updated metric name to kube_node_status_addresses to be more accurate
• added new metric to the docs/node-metrics.md
• added comment to _info metric (I think that's where you meant?)

[stonith]

added the missed node label

[mrueg]

/lgtm

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, stonith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment