feat: Generate OpenVX data for every release #2276
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||
| name: openvex | ||||||
|
|
||||||
| on: | ||||||
| workflow_dispatch: | ||||||
| push: | ||||||
| tags: | ||||||
| - 'v*.*.*' | ||||||
| jobs: | ||||||
| vexctl: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Checkout code | ||||||
| uses: actions/checkout@v4 | ||||||
| - name: Set environment variables | ||||||
| run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV | ||||||
| - uses: openvex/generate-vex@c59881b41451d7ccba5c3b74cd195382b8971fcd | ||||||
| # Refer: https://github.com/openvex/vexctl#operational-model | ||||||
| name: Run vexctl | ||||||
shafeeqes marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| with: | ||||||
| product: pkg:golang/kubernetes/kube-state-metrics@${{ env.RELEASE_VERSION }} | ||||||
|
There was a problem hiding this comment.
Suggested change
should this be the golang package name? There was a problem hiding this comment. There was a problem hiding this comment. Why the v2? Is it not covered by the env? There was a problem hiding this comment. v2 is because it expects the full name of the golang package. |
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid running
openvexfor all releases would generate unnecessary noise, since we generally only maintain the latest release branches. Can we restrict this to that only? cc @mruegThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is restricted only to a pushed tag. See line 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to run on release creation. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, better to run on releases than tags.