Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kube_pod_container_status_last_terminated_timestamp metric #2291

Conversation

tetianakravchenko
Copy link
Contributor

What this PR does / why we need it:
Adds kube_pod_container_status_last_terminated_timestamp metric to report the time when container was last time terminated with the kube_pod_container_status_last_terminated_reason. This metric is useful for cases like getting the crash situation - as described in this issue: #1805 (comment)

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds a new metric in cases when the kube_pod_container_status_last_terminated_reason is reported

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @tetianakravchenko!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@dashpole
Copy link

/triage accepted
/assign @rexagod

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2024
@rexagod
Copy link
Member

rexagod commented Jan 17, 2024

@tetianakravchenko Tests seem to be failing here.

…ests

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
…ated_timestamp in pod tests

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Contributor Author

@tetianakravchenko Tests seem to be failing here.

Hey @rexagod I've fixed tests, please have a look

@tetianakravchenko
Copy link
Contributor Author

Hey @rexagod @mrueg could you please check this PR?

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a nit. :)

func createPodContainerStatusLastTerminatedTimestampFamilyGenerator() generator.FamilyGenerator {
return *generator.NewFamilyGeneratorWithStability(
"kube_pod_container_status_last_terminated_timestamp",
"Last terminated time for a pod container, when container was terminated with kube_pod_container_status_last_terminated_reason, in unix timestamp.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Last terminated time for a pod container, when container was terminated with kube_pod_container_status_last_terminated_reason, in unix timestamp.",
"Last terminated time for a pod container in unix timestamp.",

Is when container was terminated with kube_pod_container_status_last_terminated_reason necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rexagod , thank you for the feedback! I've tried to be more precise in the description, but I think you are right, there is no need to keep it.
Cleaned it up in this commit - 393430e, please have a look

…_timestamp' metric

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@StephanErb
Copy link

This feature would be super helpful! Anything missing to get this in? :)

@tetianakravchenko
Copy link
Contributor Author

Hey @rexagod could you please have another look on this PR?

@mrueg
Copy link
Member

mrueg commented Mar 25, 2024

/lgtm

Thanks for your contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, tetianakravchenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 97c710b into kubernetes:main Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants