Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to reflect the latest patch release #2316

Closed
wants to merge 2 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 18, 2024

Reflect patch release changes on main, which was not the case with 2.10.1 since that diverged and was never merged back into main (around backporting concerns). I believe in the future we can merge everything back into main to reflect the latest version changes in main, but diverge the release branches starting from the pre-merge commit to make sure backports are clean and maintainable (these will not be merged back into the default branch).

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2024
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Feb 18, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
This was referenced Feb 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2024
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Feb 20, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Feb 20, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
To primarily avoid conflicts and allow for automations.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Reflect patch release changes on main, which was not the case with
2.10.1 since that diverged and was never merged back into main (around
backporting concerns).

I believe in the future we can merge everything
back into main to reflect the latest version changes in main, but
diverge the release branches starting from the pre-merge commit to make
sure backports are clean and maintainable (these will not be merged back
into the default branch).

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2024
@dashpole
Copy link

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2024
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 4, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@@ -20,6 +20,7 @@ limitations under the License.
package tools

import (
_ "github.com/Kunde21/markdownfmt/v3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_ "github.com/Kunde21/markdownfmt/v3"
_ "github.com/Kunde21/markdownfmt/v3/cmd/markdownfmt"

rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 7, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 7, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod mentioned this pull request Mar 7, 2024
2 tasks
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 7, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 11, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 11, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/kube-state-metrics that referenced this pull request Mar 11, 2024
Blocked by kubernetes#2316.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Mar 11, 2024

/close
Superseded by #2317.

@k8s-ci-robot
Copy link
Contributor

@rexagod: Closed this PR.

In response to this:

/close
Superseded by #2317.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants