fix: use --track-unscheduled-pods to select unscheduled pods in Daemonset sharding

[CatherineF-dev]

What this PR does / why we need it:

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2353

Tested using minikube

[mrueg]

Will this supersede #2373 ?

[CatherineF-dev]

Will this supersede #2373 ?

Yes.

[dgrisonnet]

/assign
/triage accepted

[mrueg]

/hold
for others to review.
/lgtm

[CatherineF-dev]

/lgtm to trigger tide

[logicalhan]

tests?

[diranged]

@logicalhan Can we just skip that for now? We've been waiting for 6 weeks to #2374 resolved, and we're having daily pain points with KSM right now in our environment. While I appreciate adding tests, we're literally removing code and making it simpler here.. can we bypass this and just get a fix in ASAP?

[logicalhan]

@logicalhan Can we just skip that for now? We've been waiting for 6 weeks to #2374 resolved, and we're having daily pain points with KSM right now in our environment. While I appreciate adding tests, we're literally removing code and making it simpler here.. can we bypass this and just get a fix in ASAP?

How do you know the fix works without tests?

[CatherineF-dev]

@rexagod fixed.

[dgrisonnet]

LGTM

[mrueg]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jeffmccune]

@CatherineF-dev @mrueg @dgrisonnet FYI, I ran into some very easy to overlook syntax errors in this CL that eagle-eyed jsonnet complained loudly about when trying to customize kube-prometheus.

Please take a look at #2454 for a quick fix.