Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: publish openvex on release #2398

Merged
merged 4 commits into from
Jun 18, 2024
Merged

ci: publish openvex on release #2398

merged 4 commits into from
Jun 18, 2024

Conversation

ricardoapl
Copy link
Member

What this PR does / why we need it:

Append OpenVEX data to release, not just to stdout

How does this change affect the cardinality of KSM:

Does not change cardinality

Which issue(s) this PR fixes:

Part of #2274

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2024
@mrueg mrueg mentioned this pull request May 28, 2024
Merged
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024
@ricardoapl ricardoapl changed the title [WIP] Publish openvex on release ci: publish openvex on release Jun 17, 2024
@ricardoapl ricardoapl marked this pull request as ready for review June 17, 2024 08:34
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@ricardoapl
Publish OpenVEX data on release
9dfddac 
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
@ricardoapl
Avoid trigger OpenVEX on pre-release
2bd0b60 
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
@ricardoapl
Fix permissions for uploading to release
fba4a75 
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
@ricardoapl
Apply consistent format across workflow files
4269ab1 
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
@mrueg
Copy link
Member

mrueg commented Jun 18, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, ricardoapl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 086af0c into kubernetes:main Jun 18, 2024
12 checks passed
@ricardoapl ricardoapl mentioned this pull request Jun 27, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@mrueg mrueg Awaiting requested review from mrueg

Assignees

@mrueg mrueg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ricardoapl @k8s-ci-robot @mrueg