-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(options): Slightly improve comments for the NodeType
set type
#2414
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LaikaN57 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The committers listed above are authorized under a signed CLA. |
Welcome @LaikaN57! |
cc: @mickeyzzc |
/hold I might change NodeType back to string. Because got one comment that existing NodeType is a little confusing. |
/assign @CatherineF-dev |
What this PR does / why we need it: Improves docs to help developers.
How does this change affect the cardinality of KSM: does not change cardinality
Which issue(s) this PR fixes: n/a
Updates: d1f04c2